[Mesa-dev] [Mesa-stable] [PATCH] spirv: Add support for the HelperInvocation builtin

Andres Gomez agomez at igalia.com
Mon Sep 4 14:33:19 UTC 2017


Jason, has this patch fallen through the cracks ?

On Mon, 2017-08-21 at 22:11 -0700, Jason Ekstrand wrote:
> I have no idea how this got missed but it's been missing since forever.
> 
> Cc: mesa-stable at lists.freedesktop.org
> ---
>  src/compiler/spirv/vtn_variables.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c
> index 6a8776b..87cb935 100644
> --- a/src/compiler/spirv/vtn_variables.c
> +++ b/src/compiler/spirv/vtn_variables.c
> @@ -1121,6 +1121,10 @@ vtn_get_builtin_location(struct vtn_builder *b,
>        *location = FRAG_RESULT_DEPTH;
>        assert(*mode == nir_var_shader_out);
>        break;
> +   case SpvBuiltInHelperInvocation:
> +      *location = SYSTEM_VALUE_HELPER_INVOCATION;
> +      set_mode_system_value(mode);
> +      break;
>     case SpvBuiltInNumWorkgroups:
>        *location = SYSTEM_VALUE_NUM_WORK_GROUPS;
>        set_mode_system_value(mode);
> @@ -1177,7 +1181,6 @@ vtn_get_builtin_location(struct vtn_builder *b,
>        *location = SYSTEM_VALUE_VIEW_INDEX;
>        set_mode_system_value(mode);
>        break;
> -   case SpvBuiltInHelperInvocation:
>     default:
>        unreachable("unsupported builtin");
>     }
-- 
Br,

Andres


More information about the mesa-dev mailing list