[Mesa-dev] [PATCH 2/3] mesa: replace date/time macros with MESA_GIT_SHA1

[Eric Engestrom]

On Tuesday, 2017-09-05 15:23:24 +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Former is non-deterministic and compilers throw a warning about it.
> 
> Cc: Rob Herring <robh at kernel.org>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> I think the patch is a good idea, although kind of split about it.
> Any arguments for/against would be appreciated.

The argument against is that someone downloading a release tarball and
doing a debug build of it will lose the build date/time information,
but IMO someone doing that is someone who will know which version
they're using, so there's no need to print this information here.
(not that build date/time means anything anyway...)

Patches 1 & 2 are:
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

> ---
>  src/mesa/main/context.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c
> index be3f3610117..cc37a0dc4dc 100644
> --- a/src/mesa/main/context.c
> +++ b/src/mesa/main/context.c
> @@ -138,6 +138,7 @@
>  #include "math/m_matrix.h"
>  #include "main/dispatch.h" /* for _gloffset_COUNT */
>  #include "macros.h"
> +#include "git_sha1.h"
>  
>  #ifdef USE_SPARC_ASM
>  #include "sparc/sparc.h"
> @@ -398,10 +399,13 @@ one_time_init( struct gl_context *ctx )
>  
>        atexit(one_time_fini);
>  
> -#if defined(DEBUG) && defined(__DATE__) && defined(__TIME__)
> +#if defined(DEBUG)
>        if (MESA_VERBOSE != 0) {
> -         _mesa_debug(ctx, "Mesa " PACKAGE_VERSION " DEBUG build %s %s\n",
> -                     __DATE__, __TIME__);
> +         _mesa_debug(ctx, "Mesa " PACKAGE_VERSION " DEBUG build"
> +#ifdef MESA_GIT_SHA1
> +                     " (" MESA_GIT_SHA1 ")"
> +#endif
> +                     "\n");
>        }
>  #endif
>     }
> -- 
> 2.14.1
>