[Mesa-dev] [PATCH] radeon/uvd: fix the assertion check for YUYV format

[Leo Liu]

On 09/06/2017 03:51 AM, Michel Dänzer wrote:
> On 06/09/17 02:37 AM, Leo Liu wrote:
>> Fixes:7319ff87("radeon/uvd: add YUYV format support for target buffer")
>>
>> Signed-off-by: Leo Liu <leo.liu at amd.com>
>> ---
>>   src/gallium/drivers/radeon/radeon_uvd.c | 8 +++++---
>>   1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/gallium/drivers/radeon/radeon_uvd.c b/src/gallium/drivers/radeon/radeon_uvd.c
>> index 00d6267018..5330b03872 100644
>> --- a/src/gallium/drivers/radeon/radeon_uvd.c
>> +++ b/src/gallium/drivers/radeon/radeon_uvd.c
>> @@ -1588,9 +1588,11 @@ void ruvd_set_dt_surfaces(struct ruvd_msg *msg, struct radeon_surf *luma,
>>   			msg->body.decode.dt_chroma_bottom_offset = msg->body.decode.dt_chroma_top_offset;
>>   		}
>>   
>> -		assert(luma->u.legacy.bankw == chroma->u.legacy.bankw);
>> -		assert(luma->u.legacy.bankh == chroma->u.legacy.bankh);
>> -		assert(luma->u.legacy.mtilea == chroma->u.legacy.mtilea);
>> +		if (chroma)
> Missing opening curly brace.

oops. I was reading this piece of the code and found this assertion 
problem, and quickly generate a patch without building test. I should be 
more careful.
I will add it on.

Thanks,
Leo

>
>
>> +			assert(luma->u.legacy.bankw == chroma->u.legacy.bankw);
>> +			assert(luma->u.legacy.bankh == chroma->u.legacy.bankh);
>> +			assert(luma->u.legacy.mtilea == chroma->u.legacy.mtilea);
>> +		}
>
>
>