[Mesa-dev] [PATCH 03/10] dri: Add 10 bpc formats as available formats.

[Tapani Pälli]

On 09/06/2017 11:19 AM, Mario Kleiner wrote:
> On 09/06/2017 08:46 AM, Tapani Pälli wrote:
>>
>>
>> On 09/06/2017 09:30 AM, Tapani Pälli wrote:
>>> verified values against drm_fourcc.h,
>>>
>>> Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
>>
>> One nit though, other values are aligned with a tab while your 
>> additions use spaces. Since tab is used all over this header maybe 
>> these changes should continue that fine tradition, or then just 
>> convert all of those away at one go. I don't have strong opinion here.
>>
> 
> Thanks for the review. Yes, that block has tabs, but it is a bit 
> confusing, as that header file seems to randomly change between tabs and 
> no-tabs for indentation and alignment every couple of lines, essentially 
> randomly for each code block? And the Mesa code formatting guidelines 
> say "3-space indentation, no tabs"? I can try to fudge it in place for 
> that specific block.

Right .. it's messy .. maybe do like the block does for now. I'll go 
through the rest of patches in coming days and do a CI run for this set.


> -mario
> 
>>
>>> On 09/05/2017 08:01 AM, Mario Kleiner wrote:
>>>> Used to support ARGB2101010 and XRGB2101010
>>>> winsys framebuffers / drawables, but added
>>>> other 10 bpc fourcc's as well for consistency
>>>> with definitions in wayland_drm.h, gbm.h, and
>>>> drm_fourcc.h.
>>>>
>>>> Signed-off-by: Mario Kleiner <mario.kleiner.de at gmail.com>
>>>> ---
>>>>   include/GL/internal/dri_interface.h | 8 ++++++++
>>>>   1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/include/GL/internal/dri_interface.h 
>>>> b/include/GL/internal/dri_interface.h
>>>> index 1c91bde..195c2a7 100644
>>>> --- a/include/GL/internal/dri_interface.h
>>>> +++ b/include/GL/internal/dri_interface.h
>>>> @@ -1246,6 +1246,14 @@ struct __DRIdri2ExtensionRec {
>>>>   #define __DRI_IMAGE_FOURCC_ABGR8888    0x34324241
>>>>   #define __DRI_IMAGE_FOURCC_XBGR8888    0x34324258
>>>>   #define __DRI_IMAGE_FOURCC_SARGB8888    0x83324258
>>>> +#define __DRI_IMAGE_FOURCC_ARGB2101010  0x30335241
>>>> +#define __DRI_IMAGE_FOURCC_XRGB2101010  0x30335258
>>>> +#define __DRI_IMAGE_FOURCC_ABGR2101010  0x30334241
>>>> +#define __DRI_IMAGE_FOURCC_XBGR2101010  0x30334258
>>>> +#define __DRI_IMAGE_FOURCC_RGBA1010102  0x30334152
>>>> +#define __DRI_IMAGE_FOURCC_RGBX1010102  0x30335852
>>>> +#define __DRI_IMAGE_FOURCC_BGRA1010102  0x30334142
>>>> +#define __DRI_IMAGE_FOURCC_BGRX1010102  0x30335842
>>>>   #define __DRI_IMAGE_FOURCC_YUV410    0x39565559
>>>>   #define __DRI_IMAGE_FOURCC_YUV411    0x31315559
>>>>   #define __DRI_IMAGE_FOURCC_YUV420    0x32315559
>>>>
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev