[Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

[Emil Velikov]

On 5 August 2017 at 00:25, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> As mentioned in previous commit the negative tests in dEQP expect the
> arguments to be evaluated in particular order.
>
> Namely - first the dpy, then the config, followed by the surface/window.
>
> Move the check further down or executing the test below will produce
> the following error.
>
>    dEQP-EGL.functional.negative_api.create_pbuffer_surface
>
>
>    <Section Name="Test2" Description="EGL_BAD_CONFIG is generated if config is not an EGL frame buffer configuration">
>       <Text>eglCreateWindowSurface(0x9bfff0f150, 0xffffffffffffffff, 0x0000000000000000, { EGL_NONE });</Text>
>       <Text>// 0x0000000000000000 returned</Text>
>       <Text>// ERROR expected: EGL_BAD_CONFIG, Got: EGL_BAD_NATIVE_WINDOW</Text>
>    </Section>
>
FTR dEQP has been "fixed" (by removing the test all together) to not
generate the above error. At the same the Pixman equivalent is still
buggy, hence the v2 of commit
df8efd5b74d45e2bfb977a92dcd3db86abd6b143.

I've sent patches [1] to restore the test and fix the buggy ones.

As those land, I would love to have symmetrical Window/Pixman paths. Be that:
 - merging this patch (with polished commit message), or
 - updating the Window path to be like this one.

I have no preference on which one ;-)

Thanks
Emil

[1] https://android-review.googlesource.com/#/q/owner:emil.l.velikov%2540gmail.com