[Mesa-dev] [PATCH 1/2] radv: remove unused radv_meta_saved_state::vertex_saved field

[Samuel Pitoiset]

Just noticed that old_vertex_bindings should also be removed in this patch.

On 09/06/2017 03:53 PM, Samuel Pitoiset wrote:
> It's always false.
> 
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>   src/amd/vulkan/radv_meta.c | 6 ------
>   src/amd/vulkan/radv_meta.h | 1 -
>   2 files changed, 7 deletions(-)
> 
> diff --git a/src/amd/vulkan/radv_meta.c b/src/amd/vulkan/radv_meta.c
> index af56f493b4..b17076703a 100644
> --- a/src/amd/vulkan/radv_meta.c
> +++ b/src/amd/vulkan/radv_meta.c
> @@ -43,7 +43,6 @@ radv_meta_save_novertex(struct radv_meta_saved_state *state,
>   				dynamic_mask);
>   
>   	memcpy(state->push_constants, cmd_buffer->push_constants, MAX_PUSH_CONSTANTS_SIZE);
> -	state->vertex_saved = false;
>   }
>   
>   void
> @@ -53,11 +52,6 @@ radv_meta_restore(const struct radv_meta_saved_state *state,
>   	radv_CmdBindPipeline(radv_cmd_buffer_to_handle(cmd_buffer), VK_PIPELINE_BIND_POINT_GRAPHICS,
>   			     radv_pipeline_to_handle(state->old_pipeline));
>   	cmd_buffer->state.descriptors[0] = state->old_descriptor_set0;
> -	if (state->vertex_saved) {
> -		memcpy(cmd_buffer->state.vertex_bindings, state->old_vertex_bindings,
> -		       sizeof(state->old_vertex_bindings));
> -		cmd_buffer->state.vb_dirty |= (1 << RADV_META_VERTEX_BINDING_COUNT) - 1;
> -	}
>   
>   	cmd_buffer->state.dirty |= RADV_CMD_DIRTY_PIPELINE;
>   
> diff --git a/src/amd/vulkan/radv_meta.h b/src/amd/vulkan/radv_meta.h
> index d84d8cb68c..8b7b664b22 100644
> --- a/src/amd/vulkan/radv_meta.h
> +++ b/src/amd/vulkan/radv_meta.h
> @@ -36,7 +36,6 @@ extern "C" {
>   #define RADV_META_VERTEX_BINDING_COUNT 2
>   
>   struct radv_meta_saved_state {
> -	bool vertex_saved;
>   	struct radv_vertex_binding old_vertex_bindings[RADV_META_VERTEX_BINDING_COUNT];
>   	struct radv_descriptor_set *old_descriptor_set0;
>   	struct radv_pipeline *old_pipeline;
>