[Mesa-dev] [PATCH 06/17] i965: Drop a useless ret == 0 check.

Kenneth Graunke kenneth at whitecape.org
Wed Sep 6 15:10:25 UTC 2017


On Wednesday, September 6, 2017 2:31:11 AM PDT Chris Wilson wrote:
> Quoting Kenneth Graunke (2017-09-06 01:09:39)
> > Prior to the previous patch, we would pwrite the batchbuffer contents,
> > and wanted to skip the execbuffer if that failed.  Now, we write things
> > directly to the map, so we don't need this check.
> > ---
> >  src/mesa/drivers/dri/i965/intel_batchbuffer.c | 40 ++++++++++++---------------
> >  1 file changed, 18 insertions(+), 22 deletions(-)
> > 
> > diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
> > index 9b37470f926..df094bb6047 100644
> > --- a/src/mesa/drivers/dri/i965/intel_batchbuffer.c
> > +++ b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
> > @@ -199,8 +199,6 @@ intel_batchbuffer_reset_to_saved(struct brw_context *brw)
> >  void
> >  intel_batchbuffer_free(struct intel_batchbuffer *batch)
> >  {
> > -   free(batch->cpu_map);
> 
> Stray from previous patch.
> -Chris

Fixed locally - squashed it into the previous patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170906/ea28c20b/attachment.sig>


More information about the mesa-dev mailing list