[Mesa-dev] [PATCH v6 3/6] mesa/st: glsl_to_tgsi: add tests for the new temporary lifetime tracker

[Ilia Mirkin]

One might ask the question of why st/mesa is being built at all
without HAVE_GALLIUM...

On Wed, Sep 6, 2017 at 12:11 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Hi Gert,
>
> This seems to have broken the "classic only" build - see
> https://travis-ci.org/evelikov/Mesa/jobs/272529714.
> In there the following is executed
>
> DRI_LOADERS="--enable-glx --enable-gbm --enable-egl
> --with-platforms=x11,drm,surfaceless,wayland --enable-osmesa"
> DRI_DRIVERS="i915,i965,radeon,r200,swrast,nouveau"
> GALLIUM_ST="--enable-dri --disable-opencl --disable-xa --disable-nine
> --disable-xvmc --disable-vdpau --disable-va --disable-omx
> --disable-gallium-osmesa"
> GALLIUM_DRIVERS=""
> VULKAN_DRIVERS=""
>
> ./autogen.sh --enable-debug \
>         $DRI_LOADERS \
>         --with-dri-drivers=$DRI_DRIVERS \
>         $GALLIUM_ST \
>         --with-gallium-drivers=$GALLIUM_DRIVERS \
>         --with-vulkan-drivers=$VULKAN_DRIVERS \
>         --disable-llvm-shared-libs
>
> make && make check
>
> On 4 July 2017 at 15:18, Gert Wollny <gw.fossdev at gmail.com> wrote:
>> This patch adds a set of unit tests for the new lifetime tracker.
>> ---
>>  configure.ac                                       |    1 +
>>  src/mesa/Makefile.am                               |    2 +-
>>  src/mesa/state_tracker/tests/Makefile.am           |   36 +
>>  .../tests/test_glsl_to_tgsi_lifetime.cpp           | 1364 ++++++++++++++++++++
>>  4 files changed, 1402 insertions(+), 1 deletion(-)
>>  create mode 100644 src/mesa/state_tracker/tests/Makefile.am
>>  create mode 100644 src/mesa/state_tracker/tests/test_glsl_to_tgsi_lifetime.cpp
>>
>> diff --git a/configure.ac b/configure.ac
>> index 1e7a3be73f..d49aa83082 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -2850,6 +2850,7 @@ AC_CONFIG_FILES([Makefile
>>                 src/mesa/drivers/osmesa/osmesa.pc
>>                 src/mesa/drivers/x11/Makefile
>>                 src/mesa/main/tests/Makefile
>> +               src/mesa/state_tracker/tests/Makefile
>>                 src/util/Makefile
>>                 src/util/tests/hash_table/Makefile
>>                 src/vulkan/Makefile])
>> diff --git a/src/mesa/Makefile.am b/src/mesa/Makefile.am
>> index 97a9bbd8c2..865735be27 100644
>> --- a/src/mesa/Makefile.am
>> +++ b/src/mesa/Makefile.am
>> @@ -19,7 +19,7 @@
>>  # FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
>>  # IN THE SOFTWARE.
>>
>> -SUBDIRS = . main/tests
>> +SUBDIRS = . main/tests state_tracker/tests
>>
> New folder should be conditionally included, ideally with a comment
> "Tests depend on libmesagallium.la.... "
>
> if HAVE_GALLIUM
> SUBDIRS += state_tracker/tests
> endif
>
> Do give it a try and polish any other nitpicks.
>
> Thanks
> Emil
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev