[Mesa-dev] [PATCH mesa 2/2] mesa: allow user to set MESA_NO_ERROR=0

[Michel Dänzer]

On 06/09/17 11:23 PM, Eric Engestrom wrote:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102530
> Cc: Michel Dänzer <michel at daenzer.net>
> Cc: Alexandre Demers <alexandre.f.demers at gmail.com>
> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> ---
>  src/mesa/main/context.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c
> index cd3eccea20..1c4232d298 100644
> --- a/src/mesa/main/context.c
> +++ b/src/mesa/main/context.c
> @@ -123,6 +123,7 @@
>  #include "shared.h"
>  #include "shaderobj.h"
>  #include "shaderimage.h"
> +#include "util/debug.h"
>  #include "util/disk_cache.h"
>  #include "util/strtod.h"
>  #include "stencil.h"
> @@ -1213,7 +1214,7 @@ _mesa_initialize_context(struct gl_context *ctx,
>     /* KHR_no_error is likely to crash, overflow memory, etc if an application
>      * has errors so don't enable it for setuid processes.
>      */
> -   if (getenv("MESA_NO_ERROR")) {
> +   if (env_var_as_boolean("MESA_NO_ERROR", false)) {
>  #if !defined(_WIN32)
>        if (geteuid() == getuid())
>  #endif
> 

This is a nice first step in the right direction.

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


However, longer term we need to be able to disable the "no error"
behaviour even if the application explicitly enables it, either via
MESA_NO_ERROR=0 or another mechanism.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer