[Mesa-dev] [PATCH 13/17] i965: Use a separate state buffer, but avoid changing flushing behavior.

Kenneth Graunke kenneth at whitecape.org
Fri Sep 8 07:12:43 UTC 2017


On Wednesday, September 6, 2017 5:12:10 AM PDT Chris Wilson wrote:
> Quoting Kenneth Graunke (2017-09-06 01:09:46)
> > @@ -156,11 +158,14 @@ intel_batchbuffer_reset(struct intel_batchbuffer *batch,
> >     batch->map = brw_bo_map(NULL, batch->bo, MAP_READ | MAP_WRITE);
> >     batch->map_next = batch->map;
> >  
> > +   batch->state_bo = brw_bo_alloc(bufmgr, "statebuffer", STATE_SZ, 4096);
> > +   batch->state_map = brw_bo_map(NULL, batch->state_bo, MAP_READ | MAP_WRITE);
> > +   batch->state_used = 1; /* don't make 0 valid */
> 
> You'll want to mark this state_bo with EXEC_OBJECT_CAPTURE.
> -Chris

Yikes, good point!  I hadn't actually realized that we'd lose the ability
to capture the state buffer on earlier kernels.  That's unfortunate, but
there's not much we can do.

Fixed locally.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170908/1d29a173/attachment.sig>


More information about the mesa-dev mailing list