[Mesa-dev] [PATCH mesa 00/10] make use of env_var_as_boolean()

Eric Engestrom eric.engestrom at imgtec.com
Fri Sep 8 12:40:46 UTC 2017


After fixing MESA_NO_ERROR=0 yesterday, I decided to have a look and do
the same change with a bunch of other env vars.

I also updated the docs to suggest setting true/false as it's usually
clearer (what's LIBGL_DRI3_DISABLE=0? am I disabling or enabling?
doesn't help that it used to do the same whether it was 0 or 1), but I'm
happy to keep 0/1 if people prefer it.

There are a lot more getenv() that could be converted, but I got bored of
looking at env vars to see if they're used as booleans or when the value
matters.

Cheers,
  Eric


Eric Engestrom (10):
  gbm: turn GBM_ALWAYS_SOFTWARE into a boolean
  glx: turn LIBGL_DIAGNOSTIC into a boolean
  egl+glx: turn LIBGL_ALWAYS_SOFTWARE into a boolean
  glx: turn LIBGL_ALLOW_SOFTWARE into a boolean
  glx: turn LIBGL_ALWAYS_INDIRECT into a boolean
  egl+glx: turn LIBGL_DRI3_DISABLE into a boolean
  glx: turn LIBGL_DUMP_VISUALID into a boolean
  glx: turn LIBGL_PROFILE_CORE into a boolean
  glx: turn LIBGL_NO_DRAWARRAYS into a boolean
  util/disk_cache: turn MESA_GLSL_CACHE_DISABLE into a boolean

 docs/envvars.html                       | 12 ++++++------
 docs/libGL.txt                          |  2 +-
 docs/releasing.html                     |  4 ++--
 src/compiler/glsl/tests/cache_test.c    |  4 ++--
 src/egl/Android.mk                      |  1 +
 src/egl/Makefile.am                     |  6 ++++--
 src/egl/SConscript                      |  2 ++
 src/egl/drivers/dri2/platform_wayland.c |  3 ++-
 src/egl/drivers/dri2/platform_x11.c     |  5 +++--
 src/gbm/Android.mk                      |  5 ++++-
 src/gbm/Makefile.am                     |  1 +
 src/gbm/backends/dri/gbm_dri.c          |  6 ++++--
 src/glx/Makefile.am                     |  1 +
 src/glx/SConscript                      |  1 +
 src/glx/apple/apple_glx_context.c       |  4 +++-
 src/glx/apple/apple_glx_log.c           |  3 ++-
 src/glx/apple/apple_glx_pbuffer.c       |  6 ++++--
 src/glx/apple/apple_visual.c            |  8 ++++----
 src/glx/glxcmds.c                       |  2 +-
 src/glx/glxext.c                        | 12 ++++++++----
 src/glx/indirect_glx.c                  |  6 +++++-
 src/util/disk_cache.c                   |  3 ++-
 22 files changed, 63 insertions(+), 34 deletions(-)

-- 
Cheers,
  Eric



More information about the mesa-dev mailing list