[Mesa-dev] [PATCH] Android: fix undeclared identifier 'gfx9d_reg_table'

[Nicolai Hähnle]

On 09.09.2017 19:17, Chih-Wei Huang wrote:
> Since commit 552aaa11 the compiler complains:
> 
> external/mesa/src/amd/common/ac_debug.c:124:51: error: use of undeclared identifier 'gfx9d_reg_table'; did you mean 'sid_reg_table'?
>                  reg = find_register(gfx9d_reg_table, ARRAY_SIZE(gfx9d_reg_table), offset);
>                                                                  ^~~~~~~~~~~~~~~
>                                                                  sid_reg_table
> 
> It's because the commit ef97cc0c ("radeonsi/gfx9: add IB parser support")
> add gfx9d.h as a recipe of sid_tables.h. But the corresponding Android.mk
> was not updated. However, it's not spotted since gfx9d_reg_table is not
> really used until commit 552aaa11 was landed.
> 
> Fixes: 552aaa11 (ac/debug: take ASIC generation into account when printing registers)
> 
> Signed-off-by: Chih-Wei Huang <cwhuang at linux.org.tw>

Sorry for the mess!

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>


> ---
>   src/amd/Android.common.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/amd/Android.common.mk b/src/amd/Android.common.mk
> index 4e2d0f9..4ef7f17 100644
> --- a/src/amd/Android.common.mk
> +++ b/src/amd/Android.common.mk
> @@ -44,7 +44,7 @@ LOCAL_GENERATED_SOURCES := $(addprefix $(intermediates)/, $(AMD_GENERATED_FILES)
>   $(LOCAL_GENERATED_SOURCES): PRIVATE_PYTHON := $(MESA_PYTHON2)
>   $(LOCAL_GENERATED_SOURCES): PRIVATE_CUSTOM_TOOL = $(PRIVATE_PYTHON) $^ > $@
>   
> -$(intermediates)/common/sid_tables.h: $(LOCAL_PATH)/common/sid_tables.py $(MESA_TOP)/src/amd/common/sid.h
> +$(intermediates)/common/sid_tables.h: $(LOCAL_PATH)/common/sid_tables.py $(LOCAL_PATH)/common/sid.h $(LOCAL_PATH)/common/gfx9d.h
>   	$(transform-generated-source)
>   
>   LOCAL_C_INCLUDES := \
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.