[Mesa-dev] [PATCH v3 0/5] VK_EXT_debug_report v3

[Jason Ekstrand]

Left a couple of tiny comments.  With those fixed,

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

Thanks for working on this!

On Sun, Sep 10, 2017 at 10:29 PM, Tapani Pälli <tapani.palli at intel.com>
wrote:

> Here's v3 of VK_EXT_debug_report with fixes to issues found by Jason.
>
> Some example reports:
>
> real performance warning on Haswell:
>    PERFORMANCE WARNING: [anv] Code 0 (loc 272) (type
> VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT) : vulkan/anv_image.c: Implement
> gen7 HiZ
>
> simulated error via vk_errorf:
>    ERROR: [anv] Code 0 (loc 1038) (type VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT)
> : vulkan/anv_allocator.c:1038: game over man, game over
> (VK_ERROR_MEMORY_MAP_FAILED)
>
> (line number may be considered 'duplicate information' but on the other
> hand, app/layer might not print loc but just the message)
>
>
> Tapani Pälli (5):
>   anv: implementation of VK_EXT_debug_report extension
>   anv: wire up anv_perf_warn macro to do debug reporting
>   anv: wire up vk_errorf macro to do debug reporting
>   anv: move brw_process_intel_debug_variable to happen early
>   anv: remove extra 'debug:' from anv_debug_ignored_stype
>
>  src/intel/Makefile.sources          |   1 +
>  src/intel/vulkan/anv_allocator.c    |   8 +-
>  src/intel/vulkan/anv_debug_report.c | 119 ++++++++++++++++++++++++++++
>  src/intel/vulkan/anv_device.c       |  79 +++++++++++++++----
>  src/intel/vulkan/anv_extensions.py  |   1 +
>  src/intel/vulkan/anv_formats.c      |   3 +-
>  src/intel/vulkan/anv_image.c        |  12 +--
>  src/intel/vulkan/anv_private.h      | 151 ++++++++++++++++++++++++++++++
> ++++--
>  src/intel/vulkan/anv_queue.c        |  13 ++--
>  src/intel/vulkan/anv_util.c         |  38 +++++++--
>  src/intel/vulkan/anv_wsi.c          |   6 +-
>  src/intel/vulkan/genX_cmd_buffer.c  |  15 ++--
>  src/intel/vulkan/genX_query.c       |   3 +-
>  13 files changed, 397 insertions(+), 52 deletions(-)
>  create mode 100644 src/intel/vulkan/anv_debug_report.c
>
> --
> 2.13.5
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170911/8b8311b1/attachment.html>