[Mesa-dev] [PATCH] r600/sb: remove superfluos assert

Emil Velikov emil.l.velikov at gmail.com
Mon Sep 11 16:09:39 UTC 2017


On 11 September 2017 at 15:39, Gert Wollny <gw.fossdev at gmail.com> wrote:
> The assert checks whether pshader->num_arrays != 0, but the code
> after the assert actually branches based on the same check.
>
> Removing this assert fixes:
>   piglit spec at arb_gpu_shader5@execution at samplemaskin-indirect

Both assert() and if () have existed since day 1, with below commit.
Perhaps Vadim has some ideas what happened here?

Cc: Vadim Girlin <vadimgirlin at gmail.com>
Fixes: 2cd76917934 ("r600g/sb: initial commit of the optimizing shader backend")

-Emil


More information about the mesa-dev mailing list