[Mesa-dev] [PATCH] mesa/st: Include builddir/src/compiler/glsl to fix make check

[Emil Velikov]

On 11 September 2017 at 07:59, Michel Dänzer <michel at daenzer.net> wrote:
> On 11/09/17 03:36 PM, Gert Wollny wrote:
>> Hi Michel,
>>
>> I can confirm that the problem exists on
>>
>>    8d6b97a815874c7b695471a259fe4b6689890206
>>
>> i.e.  for me ir_expression_operation.h is created in the build
>> directory - and the patch fixes compiling the test in an out of source
>> build.
>
> Hmm, weird. I get:
>
>> make -C build-amd64/src/compiler glsl/ir_expression_operation.h V=1
> make: Entering directory '/home/daenzer/src/mesa-git/mesa/build-amd64/src/compiler'
> /bin/mkdir -p ../../../src/compiler/glsl
> python2.7  ../../../src/compiler/glsl/ir_expression_operation.py enum > ../../../src/compiler/glsl/ir_expression_operation.h || (rm -f ../../../src/compiler/glsl/ir_expression_operation.h; false)
> make: Leaving directory '/home/daenzer/src/mesa-git/mesa/build-amd64/src/compiler'
>
Something really funky is happening on your setup. The header is
created in builddir here.

$ make -C mm/src/compiler glsl/ir_expression_operation.h V=1
make: Entering directory '/home/emil/development/mesa/mm/src/compiler'
/usr/bin/mkdir -p glsl
python2.7  ../../../src/compiler/glsl/ir_expression_operation.py enum
> glsl/ir_expression_operation.h || (rm -f
glsl/ir_expression_operation.h; false)
make: Leaving directory '/home/emil/development/mesa/mm/src/compiler'

That said, the patch does the right thing:

Fixes: 7be6d8fe125 ("mesa/st: glsl_to_tgsi: add tests for the new
temporary lifetime tracker")
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil