[Mesa-dev] [PATCH mesa 00/10] make use of env_var_as_boolean()

Emil Velikov emil.l.velikov at gmail.com
Mon Sep 11 17:51:09 UTC 2017


On 8 September 2017 at 13:40, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> After fixing MESA_NO_ERROR=0 yesterday, I decided to have a look and do
> the same change with a bunch of other env vars.
>
> I also updated the docs to suggest setting true/false as it's usually
> clearer (what's LIBGL_DRI3_DISABLE=0? am I disabling or enabling?
> doesn't help that it used to do the same whether it was 0 or 1), but I'm
> happy to keep 0/1 if people prefer it.
>
> There are a lot more getenv() that could be converted, but I got bored of
> looking at env vars to see if they're used as booleans or when the value
> matters.
>
I think I've spotted a couple of issues, but other than that the series is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emli


More information about the mesa-dev mailing list