[Mesa-dev] [PATCH mesa] glx: remove dead code

[Adam Jackson]

On Tue, 2017-09-12 at 16:08 +0100, Eric Engestrom wrote:
> On Wednesday, 2017-09-06 17:25:29 +0100, Emil Velikov wrote:
> > I'm not that much of an expert on things XCB, so perhaps a silly question.
> > Isn't the presence checked with the code just above the removed hunk? Namely:
> > 
> > extension = xcb_get_extension_data(c, &xcb_dri3_id);
> > if (!(extension && extension->present))
> >   return NULL;
> > 
> > extension = xcb_get_extension_data(c, &xcb_present_id);
> > if (!(extension && extension->present))
> >   return NULL;
> 
> I agree with Emil, but if I'm wrong I'm happy to keep the version
> queries and simply store them in a local variable and drop the struct
> fields.

Yeah, he's right, my bad. That said, DRI3 1.1 is in development, so at
least those version numbers are going to want to be saved in the
display state soon. Present you could lose I suppose.

- ajax