[Mesa-dev] [PATCH 3/3] radv: clear push_constant_stages when resetting a command buffer

[Bas Nieuwenhuizen]

The series is

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Tue, Sep 12, 2017 at 7:08 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Per the spec:
>
>    "Resetting a command buffer is an operation that discards any
>    previously recorded commands and puts a command buffer in the
>    initial state."
>
> As far I'm concerned, that flag can be changed by calling
> VkCmdPushConstants() (or any other functions which update it),
> so it should be cleared as well.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index 6a82867c82..d888300677 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -216,6 +216,7 @@ radv_reset_cmd_buffer(struct radv_cmd_buffer *cmd_buffer)
>                 free(up);
>         }
>
> +       cmd_buffer->push_constant_stages = 0;
>         cmd_buffer->scratch_size_needed = 0;
>         cmd_buffer->compute_scratch_size_needed = 0;
>         cmd_buffer->esgs_ring_size_needed = 0;
> --
> 2.14.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev