[Mesa-dev] [PATCH 0/4] i965: Properly handle CCS in glxBindTexImageEXT

Jason Ekstrand jason at jlekstrand.net
Tue Sep 12 23:23:01 UTC 2017


This little series fixes (I think!) a bug in glxBindTexImageEXT when using
modifiers.  Before, we were using make_shareable which resolves everything
and then permanently throws away any aux information.  In the world of
modifiers, that aux information is suddenly important.  This was causing
rendering corruptions when running with Daniel's X11 modifiers work and
using a compositor (mutter in this case).

I've Cc'd a pile of people on this patch most of whom no longer work for
Intel.  While I'm probably the most qualified person we have to work on
this, I'm nowhere near as qualified as some other people out there are.
Please review at least the commit messages and give me a sanity check.  I
have very limited knowledge of how glx and compositors interact.

Cc: Topi Pohjolainen <topi.pohjolainen at intel.com>
Cc: Chad Versace <chadversary at chromium.org>
Cc: Eric Anholt <eric at anholt.net>
Cc: Daniel Stone <daniels at collabora.com>

Jason Ekstrand (4):
  intel/isl: Add a drm_modifier_get_default_aux_state helper
  i965: Reset miptree aux state on update_image_buffer
  i965/tex_image: Reference the renderbuffer miptree in setTexBuffer2
  i965: Use prepare_external instead of make_shareable in setTexBuffer2

 src/intel/isl/isl.h                           | 20 ++++++++++++++++++++
 src/mesa/drivers/dri/i965/brw_context.c       |  4 +++-
 src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 22 ++++++++++++++++++++--
 src/mesa/drivers/dri/i965/intel_mipmap_tree.h |  3 +++
 src/mesa/drivers/dri/i965/intel_tex_image.c   | 25 +++++--------------------
 5 files changed, 51 insertions(+), 23 deletions(-)

-- 
2.5.0.400.gff86faf



More information about the mesa-dev mailing list