[Mesa-dev] [PATCH] mesa/st/tests: Correct build flags and force -std=c++11

[Emil Velikov]

Hi Gert,

On 13 September 2017 at 09:32, Gert Wollny <gw.fossdev at gmail.com> wrote:
> Include src/gallium/Automake.inc, correct the build flags
> accordingly, and force -std=c++11 because only when building
> against llvm and only with llvm >= 3.9 LLVM_CXXFLAGS
> actually provides -std=c++11.
>
Is the one character change is the only reason behind the c++11 toggle?
If so I'd just fix that and drop this hunk.

> Fixes: 7be6d8fe12  ("mesa/st: glsl_to_tgsi: add tests for the
> new temporary lifetime tracker")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102665
> ---
>  src/mesa/state_tracker/tests/Makefile.am | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/src/mesa/state_tracker/tests/Makefile.am b/src/mesa/state_tracker/tests/Makefile.am
> index cd610e0adf..29f9b5f0b8 100644
> --- a/src/mesa/state_tracker/tests/Makefile.am
> +++ b/src/mesa/state_tracker/tests/Makefile.am
> @@ -1,18 +1,18 @@
> +include $(top_srcdir)/src/gallium/Automake.inc
> +
>  AM_CFLAGS = \
>         $(PTHREAD_CFLAGS)
>
>  AM_CXXFLAGS = \
> +       -std=c++11 \
>         $(LLVM_CXXFLAGS)
>
Bear in mind - just having my first coffee of the day:
I don't see anything that requires LLVM.

>  AM_CPPFLAGS = \
> +     $(GALLIUM_DRIVER_CXXFLAGS) \
This line should be part for the above CXX flags (AM_CXXFLAGS)

With the above
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil