[Mesa-dev] [PATCH 2/5] amd/common: round cube array slice in ac_prepare_cube_coords

Nicolai Hähnle nicolai.haehnle at amd.com
Wed Sep 13 20:25:18 UTC 2017


On 13.09.2017 22:20, Dave Airlie wrote:
> On 14 September 2017 at 03:04, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
>> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
>>
>> The NIR-to-LLVM pass already does this; now the same fix covers
>> radeonsi as well.
>>
>> Fixes various tests of
>> dEQP-GLES31.functional.texture.filtering.cube_array.combinations.*
> 
> Nice to see you guys catch up, I think I asked about a lot of these workarounds
> when I wrote them and didn't get much response :-), other than radeonsi doesn't
> need them, looks like it did after all.

Indeed. In our defense, the only documentation I could find about a lot 
of these things is that they were fixed in gfx9 :)


> Reviewed-by: Dave Airlie <airlied at redhat.com>

Thanks!

> 



More information about the mesa-dev mailing list