[Mesa-dev] [PATCH v2 01/15] i965: Delete a batch size assertion that isn't very useful.
Kenneth Graunke
kenneth at whitecape.org
Wed Sep 13 20:54:03 UTC 2017
This assertion prevents you from doing intel_batchbuffer_require_space
with a size so huge it won't fit in the batchbuffer. This doesn't seem
like a common mistake, and I've never seen the assert to be useful.
Soon, I hope to have batches grow, at which point this won't make sense.
---
src/mesa/drivers/dri/i965/intel_batchbuffer.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
index 515b595bc92..cd118f6c6fc 100644
--- a/src/mesa/drivers/dri/i965/intel_batchbuffer.c
+++ b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
@@ -238,9 +238,6 @@ intel_batchbuffer_require_space(struct brw_context *brw, GLuint sz,
intel_batchbuffer_flush(brw);
}
-#ifdef DEBUG
- assert(sz < BATCH_SZ - BATCH_RESERVED);
-#endif
if (intel_batchbuffer_space(&brw->batch) < sz)
intel_batchbuffer_flush(brw);
--
2.14.1
More information about the mesa-dev
mailing list