[Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

Emil Velikov emil.l.velikov at gmail.com
Wed Sep 13 21:26:30 UTC 2017


On 13 September 2017 at 20:27, Denis Pauk <pauk.denis at gmail.com> wrote:
> Could you please commit this changes?
>
> I have not found what i need to do next after recieve "approve" for changes
> in https://www.mesa3d.org/submittingpatches.html#reviewing.
> Do i need to send new mail with "Reviewed-by: " mark?
>
Hmm nicely spotted - I thought we had a section about it. How about
something like the following.
Can you please beat it into shape and send as a patch?

Pushing patches

After the patch is reviewed, ideally, there will be $PERIOD (open for
discussion) for other developers to review the patch.
Patches that fix serious regressions (fails to build on multiple
platforms, most of piglit/CTS fails, etc.) are likely to be pushed on
a shorter notice.

Reviewed patches, are pushed to the upstream repository $REF
(https://www.mesa3d.org/repository.html#anonymous) by developers with
commit access $REF (https://www.mesa3d.org/repository.html#developer).
If you do not have access, clearly state so - normally after the ---
line as part of the patch submission.

In such a case the reviewer should push the patch.

Do poke developers if you notice that your patch has not been pushed
after $PERIOD of being reviewed.

-Emil


More information about the mesa-dev mailing list