[Mesa-dev] [PATCH 0/5] Resend of string buffer series

[Dieter Nützel]

Even for this series, too:

Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>

You 'lost' all of my former tb's.

Dieter

Am 11.09.2017 22:21, schrieb Thomas Helland:
> I think I should have addressed all review feedback pointed out
> to me by Nicolai, fixed the build issues with the tests (thanks
> to Eric and Emil) and I've discovered another bug thanks to
> strengthening the gtest test even more. I've also given it some
> more polishing and slight modifications to make comments clearer
> and more precise, and variable names better explaining their intet
> in a couple of places. Details of changes in each patch. A big thanks
> to those who have helped review this series =)
> 
> Thomas Helland (5):
>   util: Add a string buffer implementation
>   util: Add tests for the string buffer
>   glsl: Change the parser to use the string buffer
>   glcpp: Use string_buffer for line continuation removal
>   glcpp: Avoid unnecessary call to strlen
> 
>  configure.ac                                       |   1 +
>  src/compiler/glsl/glcpp/glcpp-lex.l                |   9 +-
>  src/compiler/glsl/glcpp/glcpp-parse.y              | 195 
> +++++-----------
>  src/compiler/glsl/glcpp/glcpp.h                    |   8 +-
>  src/compiler/glsl/glcpp/pp.c                       |  64 +++---
>  src/compiler/glsl/glsl_lexer.ll                    |  32 ++-
>  src/compiler/glsl/glsl_parser.yy                   | 246 
> ++++++++++-----------
>  src/util/Makefile.am                               |   5 +-
>  src/util/Makefile.sources                          |   2 +
>  src/util/string_buffer.c                           | 147 ++++++++++++
>  src/util/string_buffer.h                           |  99 +++++++++
>  src/util/tests/string_buffer/Makefile.am           |  40 ++++
>  .../tests/string_buffer/string_buffer_test.cpp     | 119 ++++++++++
>  13 files changed, 665 insertions(+), 302 deletions(-)
>  create mode 100644 src/util/string_buffer.c
>  create mode 100644 src/util/string_buffer.h
>  create mode 100644 src/util/tests/string_buffer/Makefile.am
>  create mode 100644 src/util/tests/string_buffer/string_buffer_test.cpp