[Mesa-dev] [PATCH 1/3] glsl: don't drop intructions from unreachable terminators continue branch
Timothy Arceri
tarceri at itsqueeze.com
Thu Sep 14 22:17:02 UTC 2017
On 15/09/17 04:25, Emil Velikov wrote:
> Hi Tim
>
> On 14 September 2017 at 05:47, Timothy Arceri <tarceri at itsqueeze.com> wrote:
>> These instruction will be executed on every iteration of the loop
>> we cannot drop them.
>
> This and 2/3 sound like very nice bugfixes.
> I haven't checked if they apply for 17.2 - if not can you do some backports.
To fix things properly we would really need to land all three. Patch 3
makes unrolling better but it also fixes potential bugs. That said these
have been there since day 1 and are kinda corner cases so I'm not overly
concerned about getting these in stable. If you think its worth it than
feel free, I believe they should all apply to 17.2 cleanly as no one
normally touches this code.
>
> Once people have checked the lot and confirmed everything of course.
>
> Thanks!
> Emil
>
More information about the mesa-dev
mailing list