[Mesa-dev] [PATCH 2/2] anv: set has_exec_async to false on Android

[Tapani Pälli]

On 09/15/2017 01:09 AM, Chad Versace wrote:
> On Thu 14 Sep 2017, Emil Velikov wrote:
>> On 14 September 2017 at 07:57, Tapani Pälli <tapani.palli at intel.com> wrote:
>>> Other WSI implementations set has_exec_async false for WSI buffers,
>>> so far haven't found a place to do it so we just claim to not have
>>> async exec.
>>>
>> What's the actual side-effects you're seeing? I'd imagine Jason, Chris
>> and the gang may have some tips/suggestions - be that wrt Mesa or the
>> kernel.
>>
>> I'm not saying "don't upstream this", but a comment and/or bug
>> reference will be beneficial.
>> Esp. since disabling async exec may have noticeable implication on performance.
> 
> Tapani, thanks for finding this problem. I completely overlooked it.
> 
> Instead of disabling ASYNC globally on Android, I believe the correct
> fix is to set it only on imported gralloc buffers. Anvil already does
> that for all X11 and Wayland buffers in anv_wsi.c.
> 
> I added that fix in v4 of my patch at
> https://lists.freedesktop.org/archives/mesa-dev/2017-September/169698.html.
> 

OK cool, will test the new patches!

// Tapani