[Mesa-dev] [Mesa-stable] [PATCH] Scons: LLVM 5.0 support

Emil Velikov emil.l.velikov at gmail.com
Fri Sep 15 13:00:23 UTC 2017


Hi Alexandru-Liviu,

A couple of minor suggestions, for the future.
There's no need to resend - I'll address those before pushing the
patch later today.

On 15 September 2017 at 08:26, Liviu Prodea <liviuprodea at yahoo.com> wrote:
> Signed-off-by: Prodea Alexandru-Liviu
If you set you name/email with git config this line will be correctly
generated automatically by appending "-s" - git commit -s ...

> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102318
>
> 1 new required library - LLVMBinaryFormat
>
These lines should be in the in inverse order:

Commit message

Bugzilla: ...
Cc: mesa-stable at lists.freedesktop.org (please keep that one in the
commit message)
Signed-off-by: ...

Patch is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil


More information about the mesa-dev mailing list