[Mesa-dev] [PATCH 2/2] i965: Warn for GTT fallbacks when mapping the batch/state buffers.

Chris Wilson chris at chris-wilson.co.uk
Sun Sep 17 08:58:16 UTC 2017


Quoting Kenneth Graunke (2017-09-16 09:31:27)
> This shouldn't really happen in practice, but I hit it a couple of times
> when running a driver with a bad memory leak.  We may as well hook up
> the warning, because if it ever triggers, we'll know something is wrong.

Out of curiosity, the GTT mmap also failed? If you didn't have enough
virtual space for one mmap, the other should also fail.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

How important is the requirement to flag GL_NO_MEMORY rather than
explode? Even for batch reset, we should still be able to propagate the
error back to the context (and cancel the operation to prevent further
dismay, or install some dummy).
-Chris


More information about the mesa-dev mailing list