[Mesa-dev] [PATCH] gbm: Add gbm_device_get_format_modifier_plane_count to test

Andres Gomez agomez at igalia.com
Sun Sep 17 09:52:50 UTC 2017


This is:

Reviewed-by: Andres Gomez <agomez at igalia.com>

... and pushed in a couple of minutes.

Thanks for the patch, Gert ☺


On Sun, 2017-09-17 at 00:12 +0100, Eric Engestrom wrote:
> On Saturday, 2017-09-16 16:04:15 +0000, Gert Wollny wrote:
> > Adding gbm_device_get_format_modifier_plane_count made the
> > test gbm-symbols-check fail, this patch adds the according
> > function name to the test.
> > 
> > Fixes: 8824141b8d48d9120ddbf542d6fb661046c41c62
> >  (gbm: Add a gbm_device_get_format_modifier_plane_count function)
> > 
> > Signed-off-by: Gert Wollny <gw.fossdev at gmail.com>
> 
> I guess you beat Andres by an hour on this one ^^
> 
> Both yours and Andres' patch do the same thing, although the symbol
> order differs; we might want to sort them at some point, but since it
> makes no difference, both are:
> Reviewed-by: Eric Engestrom <eric at engestrom.ch>
> 
> I'll let Andres pick which one to land.
> 
> > ---
> > Submitter has no mesa-git write access.
> > 
> >  src/gbm/gbm-symbols-check | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/gbm/gbm-symbols-check b/src/gbm/gbm-symbols-check
> > index 7ed17ddb6e..2444131e99 100755
> > --- a/src/gbm/gbm-symbols-check
> > +++ b/src/gbm/gbm-symbols-check
> > @@ -6,6 +6,7 @@ gbm_device_get_fd
> >  gbm_device_get_backend_name
> >  gbm_device_is_format_supported
> >  gbm_device_destroy
> > +gbm_device_get_format_modifier_plane_count
> >  gbm_create_device
> >  gbm_bo_create
> >  gbm_bo_create_with_modifiers
> > -- 
> > 2.13.5
> > 
> 
> 
-- 
Br,

Andres


More information about the mesa-dev mailing list