[Mesa-dev] [PATCH 3/4] radv: do not update the number of viewports in vkCmdSetViewport()

Samuel Pitoiset samuel.pitoiset at gmail.com
Mon Sep 18 09:52:11 UTC 2017


The Vulkan spec (1.0.61) says:

   "The number of viewports used by a pipeline is still specified
   by the viewportCount member of VkPipelineViewportStateCreateInfo."

So, the number of viewports is defined at pipeline creation
time and shouldn't be updated when they are set dynamically.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
 src/amd/vulkan/radv_cmd_buffer.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 1f38ecbffe..c5422c6aa5 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -2502,9 +2502,6 @@ void radv_CmdSetViewport(
 	assert(firstViewport < MAX_VIEWPORTS);
 	assert(total_count >= 1 && total_count <= MAX_VIEWPORTS);
 
-	if (cmd_buffer->state.dynamic.viewport.count < total_count)
-		cmd_buffer->state.dynamic.viewport.count = total_count;
-
 	memcpy(cmd_buffer->state.dynamic.viewport.viewports + firstViewport,
 	       pViewports, viewportCount * sizeof(*pViewports));
 
-- 
2.14.1



More information about the mesa-dev mailing list