[Mesa-dev] [PATCH v2 3/7] travis: Add clover build using llvm-3.7

[Eric Engestrom]

On Monday, 2017-09-18 11:10:37 -0400, Jan Vesely wrote:
> On Mon, 2017-09-18 at 11:13 +0100, Eric Engestrom wrote:
> > On Sunday, 2017-09-17 02:02:33 -0400, Jan Vesely wrote:
> > > v2: Use direct llvm repo link instead of alias
> > >     Enable
> > > 
> > > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > > ---
> > >  .travis.yml | 40 ++++++++++++++++++++++++++++++++++++++++
> > >  1 file changed, 40 insertions(+)
> > > 
> > > diff --git a/.travis.yml b/.travis.yml
> > > index 0012d27dc7..638ec2a78a 100644
> > > --- a/.travis.yml
> > > +++ b/.travis.yml
> > > @@ -152,6 +152,46 @@ matrix:
> > >              - libelf-dev
> > >              - libunwind8-dev
> > >      - env:
> > > +        # Disable for now since travis does not allow llvm-toolchain-trusty-3.7
> > 
> > You can drop this line now :)
> 
> Fixed locally.
> 
> > 
> > Don't 4.0 and 5.0 need the same binutils-2.26 as 3.9?

You didn't answer this; isn't it needed?

> > Speaking of, I think the OVERRIDE_PATH you added is the only way to do this.
> > 
> > With the above fixed or justified, the series is:
> > Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
> 
> thanks.
> 
> > 
> > One thing before anyone pushes this however: this will make the builds
> > much longer; is the gain of testing every supported llvm version worth it?
> 
> It does not really make builds that much worse after the ccache has
> warmed up:
> https://travis-ci.org/jvesely/mesa/builds/276686220
> building SWR is the elephant and it leaves time to build these in
> parallel.

Looking at the numbers, I'm convinced :)
Do you have push access, or do you want me to push the series for you?

(Note: typo in the subject of patch 6/7)

> possible alternatives are:
> a) use only one of radeonsi/r600, or switch back to i915g.  building
> clover is the tested part here.
> b) drop clover support for llvm<3.9 since that is required by the only
> targets that support opencl (r600/radeonsi)
> 
> I'd like to keep all supported configurations in travis. I can't really
> test 6 different llvm version locally.
> 
> Jan
> 
> > 
> > > +        # NOTE: Analogous to SWR above, building Clover is quite slow.
> > > +        - LABEL="make Gallium ST Clover LLVM-3.7"
> > > +        - BUILD=make
> > > +        - MAKEFLAGS="-j4"
> > > +        - MAKE_CHECK_COMMAND="true"
> > > +        - LLVM_VERSION=3.7
> > > +        - LLVM_CONFIG="llvm-config-${LLVM_VERSION}"
> > > +        - OVERRIDE_CC=gcc-4.7
> > > +        - OVERRIDE_CXX=g++-4.7
> > > +        - DRI_LOADERS="--disable-glx --disable-gbm --disable-egl"
> > > +        - DRI_DRIVERS=""
> > > +        - GALLIUM_ST="--disable-dri --enable-opencl --enable-opencl-icd --enable-llvm --disable-xa --disable-nine --disable-xvmc --disable-vdpau --disable-va --disable-omx-bellagio --disable-gallium-osmesa"
> > > +        # i915 most likely doesn't work with OpenCL.
> > > +        # Regardless - we're doing a quick build test here.
> > > +        - GALLIUM_DRIVERS="i915"
> > > +        - VULKAN_DRIVERS=""
> > > +        - LIBUNWIND_FLAGS="--enable-libunwind"
> > > +      addons:
> > > +        apt:
> > > +          sources:
> > > +            - sourceline: 'deb http://apt.llvm.org/trusty/ llvm-toolchain-trusty-3.7 main'
> > > +              key_url: 'http://apt.llvm.org/llvm-snapshot.gpg.key'
> > > +          packages:
> > > +            - libclc-dev
> > > +            # LLVM packaging is broken and misses these dependencies
> > > +            - libedit-dev
> > > +            - g++-4.7
> > > +            # From sources above
> > > +            - llvm-3.7-dev
> > > +            - clang-3.7
> > > +            - libclang-3.7-dev
> > > +            # Common
> > > +            - xz-utils
> > > +            - x11proto-xf86vidmode-dev
> > > +            - libexpat1-dev
> > > +            - libx11-xcb-dev
> > > +            - libelf-dev
> > > +            - libunwind8-dev
> > > +    - env:
> > >          - LABEL="make Gallium ST Other"
> > >          - BUILD=make
> > >          - MAKEFLAGS="-j4"
> > > -- 
> > > 2.13.5
> > >