[Mesa-dev] [PATCH 7/9] wayland-drm: static inline wayland_drm_buffer_get

[Emil Velikov]

On 15 September 2017 at 16:41, Daniel Stone <daniel at fooishbar.org> wrote:
> Hi,
>
> On 15 September 2017 at 16:13, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 15 September 2017 at 15:13, Daniel Stone <daniel at fooishbar.org> wrote:
>>> But if you avoid wl_resource_instance_of() and replace it with
>>> wl_resource_get_destroy_listener(), you can side-step the problem, by
>>> not relying on consistent resolution of wl_buffer_interface. That's a
>>> real bugfix. :)
>>
>> Right, I'm looking through both functions and I'm struggling a bit.
>> Can I bother you with sending a patch?
>
> Sure. This is only compile-tested, but: https://hastebin.com/mudacudeya
>
It looks a bit icky and my Wayland knowledge is limited to actually review it.

I still think that we're trying to do different things - me simplify
things, while you're focusing on fixing a bug.
That said, thanks again for the reviews - I've pushed the rest of the series.

-Emil