[Mesa-dev] [PATCH 2/2] i965: Only set planar_format if it's actually one

[Daniel Stone]

Hi,

On 19 September 2017 at 12:10, Jason Ekstrand <jason at jlekstrand.net> wrote:
> On Tue, Sep 19, 2017 at 6:40 AM, Daniel Stone <daniels at collabora.com> wrote:
>> The planar_format image property was always set even for
>> non-planar formats. This was breaking CCS support as
>> intel_from_planar is now making sure we can't have both
>> a modifier and an planar format.
>
> Could you provide a bit more detail here?  We did have issues at one point
> but I fixed them a while ago.  That said, I think this patch is probably
> correct and a good idea.  Also, how much testing of this patch have you
> done?

Not off the top of my head; I think it was when lfrb rebased DRI3 v1.1
on top of some more ISLisation and found out CCS didn't work. I tested
it at the time, though it may well have since become redundant with
upstream changes. I'll try with it backed out and see what happens.

Cheers,
Daniel