[Mesa-dev] [Bug 102904] piglit and gl45 cts linker tests regressed

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=102904

            Bug ID: 102904
           Summary: piglit and gl45 cts linker tests regressed
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Mesa core
          Assignee: prefect_ at gmx.net
          Reporter: mark.a.janes at intel.com
        QA Contact: mesa-dev at lists.freedesktop.org

the following tests regressed:
piglit.spec.!opengl 3_0.bindfragdata-link-error
piglit.spec.arb_enhanced_layouts.linker.component-layout.fs-out-overlap3
piglit.spec.arb_enhanced_layouts.linker.component-layout.fs-out-overlap
piglit.spec.arb_enhanced_layouts.linker.component-layout.fs-out-overlap4
piglit.spec.arb_enhanced_layouts.linker.component-layout.fs-out-overlap-array
piglit.spec.arb_enhanced_layouts.linker.component-layout.fs-out-type-mismatch
piglit.spec.arb_enhanced_layouts.linker.component-layout.fs-out-type-mismatch-array
piglit.spec.arb_enhanced_layouts.linker.component-layout.fs-out-overlap2

gl45-cts.gtf33.gl3tests.explicit_attrib_location.explicit_attrib_location_overlapping_ranges

By the series ending in:
704ddbcdf693079d417d831abe073caad008ab01
Author:     Nicolai Hähnle <nicolai.haehnle at amd.com>
radeonsi: set MIP_POINT_PRECLAMP to 0

This fixes a bug with nearest ("point") mip selection when the fractional
part of max_lod is in (0.5,1). In this case, the spec mandates that
we still select the mip level ceil(max_lod) in the clamping case. However,
MIP_POINT_PRECLAMP will clamp before the mip selection, which is wrong.

Supposedly this setting was originally copied from the closed Vulkan
driver, but as far as I can tell, closed Vulkan was actually changed back
recently :)

Fixes dEQP-GLES3.functional.texture.mipmap.2d.max_lod.{nearest,linear}_nearest

Fixes: f7420ef5b464 ("radeonsi: enable some sampler fields to match the closed
driver")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Dave Airlie <airlied at redhat.com>

The problematic commit is likely to be
15cae12804e * glsl/linker: fix output variable overlap check


Sample output:
/tmp/build_root/m64/lib/piglit/bin/shader_runner
/tmp/build_root/m64/lib/piglit/tests/spec/arb_enhanced_layouts/linker/component-layout/fs-out-overlap4.shader_test
-auto -fbo
piglit: debug: Requested an OpenGL 3.2 Core Context, and received a matching
4.5 context

shader link error expected, but it was successful!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170920/86178e79/attachment.html>