[Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

[Jose Fonseca]

On 19/09/17 15:14, Eric Engestrom wrote:
> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> ---
>   scons/custom.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scons/custom.py b/scons/custom.py
> index 0767ba936d410167116d..978ee5f9ec7c23a74cb9 100644
> --- a/scons/custom.py
> +++ b/scons/custom.py
> @@ -257,7 +257,7 @@ def parse_source_list(env, filename, names=None):
>       sym_table = parser.parse(src.abspath)
>   
>       if names:
> -        if isinstance(names, basestring):
> +        if isinstance(names, str):
>               names = [names]
>   
>           symbols = names
> 

I'm not sure if this won't give the wrong results for unicode strings, 
but at any rate, I don't think that should ever happen in practice.

So,

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>