[Mesa-dev] [PATCH] swr/rast: remove llvm fence/atomics from generated files

Cherniak, Bruce bruce.cherniak at intel.com
Thu Sep 21 22:32:12 UTC 2017


> On Sep 20, 2017, at 8:13 AM, Laurent Carlier <lordheavym at gmail.com> wrote:
> 
> Le mardi 19 septembre 2017, 21:25:42 CEST Tim Rowley a écrit :
>> We currently don't use these instructions, and since their API
>> changed in llvm-5.0 having them in the autogen files broke the mesa
>> release tarballs which ship with generated autogen files.
>> 
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102847
>> CC: mesa-stable at lists.freedesktop.org
>> ---
> 
> Tested-by: Laurent Carlier <lordheavym at gmail.com>

Reviewed-by: Bruce Cherniak <bruce.cherniak at intel.com> 

>> src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py | 8
>> ++++++++ 1 file changed, 8 insertions(+)
>> 
>> diff --git
>> a/src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py
>> b/src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py index
>> 025d38a..ce892a9 100644
>> --- a/src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py
>> +++ b/src/gallium/drivers/swr/rasterizer/codegen/gen_llvm_ir_macros.py
>> @@ -140,6 +140,14 @@ def parse_ir_builder(input_file):
>> 
>>                     ignore = False
>> 
>> +                    # The following functions need to be ignored in
>> openswr. +                    # API change in llvm-5.0 breaks baked autogen
>> files +                    if (
>> +                        (func_name == 'CreateFence' or
>> +                         func_name == 'CreateAtomicCmpXchg' or
>> +                         func_name == 'CreateAtomicRMW')):
>> +                        ignore = True
>> +
>>                     # The following functions need to be ignored.
>>                     if (func_name == 'CreateInsertNUWNSWBinOp' or
>>                         func_name == 'CreateMaskedIntrinsic' or
> 
> 
> -- 
> Laurent Carlier
> http://www.archlinux.org_______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev



More information about the mesa-dev mailing list