[Mesa-dev] [PATCH 3/4] i965: Rename do_flush_locked to submit_batch().

Kenneth Graunke kenneth at whitecape.org
Sun Sep 24 06:02:05 UTC 2017


do_flush_locked isn't a great name - especially given that there's no
locking going on in our code relating to execbuf.
---
 src/mesa/drivers/dri/i965/intel_batchbuffer.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
index 053c4baabd5..d564510d06a 100644
--- a/src/mesa/drivers/dri/i965/intel_batchbuffer.c
+++ b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
@@ -777,7 +777,7 @@ execbuffer(int fd,
 }
 
 static int
-do_flush_locked(struct brw_context *brw, int in_fence_fd, int *out_fence_fd)
+submit_batch(struct brw_context *brw, int in_fence_fd, int *out_fence_fd)
 {
    const struct gen_device_info *devinfo = &brw->screen->devinfo;
    __DRIscreen *dri_screen = brw->screen->driScrnPriv;
@@ -865,7 +865,8 @@ do_flush_locked(struct brw_context *brw, int in_fence_fd, int *out_fence_fd)
       brw_check_for_reset(brw);
 
    if (ret != 0) {
-      fprintf(stderr, "intel_do_flush_locked failed: %s\n", strerror(-ret));
+      fprintf(stderr, "i965: Failed to submit batchbuffer: %s\n",
+              strerror(-ret));
       exit(1);
    }
 
@@ -914,7 +915,7 @@ _intel_batchbuffer_flush_fence(struct brw_context *brw,
               brw->batch.state_relocs.reloc_count);
    }
 
-   ret = do_flush_locked(brw, in_fence_fd, out_fence_fd);
+   ret = submit_batch(brw, in_fence_fd, out_fence_fd);
 
    if (unlikely(INTEL_DEBUG & DEBUG_SYNC)) {
       fprintf(stderr, "waiting for idle\n");
-- 
2.14.1



More information about the mesa-dev mailing list