[Mesa-dev] [PATCH 1/4] i965: Convert brw_bufmgr to use C11 mutexes instead of pthreads.

[Timothy Arceri]

On 25/09/17 03:37, Kenneth Graunke wrote:
> On Sunday, September 24, 2017 7:36:17 AM PDT Jason Ekstrand wrote:
>> On September 24, 2017 01:02:21 Kenneth Graunke <kenneth at whitecape.org> wrote:
>>> There's no real advantage or disadvantage here, it's just for stylistic
>>> consistency with the rest of the codebase.
>>
>> Didn't Kristian do a bunch of work done time ago to make mutexes faster by
>> not using pthread on Linux?  If so, this should be an unnoticeable
>> performance improvement.
>>
>> --Jason
> 
> Kristian did a bunch of work that never landed.  krhmutex~1 of my tree
> has his patch - IIRC it got review feedback that was never addressed.

I took a quick look. Seems everything got addressed besides the clashing 
with C11 [1].

[1] https://lists.freedesktop.org/archives/mesa-dev/2015-January/075415.html

> 
> Someone should probably revive that.  radeonsi might get more of a boost
> at this point...

Should be fairly straight forward task if someone wanted to take a look, 
its the second and third last patches [2]. I suspect the draw overhead 
piglit test should show some improvements if we are going to see any [3].

[2] https://cgit.freedesktop.org/~kwg/mesa/log/?h=krhmutex
[3] https://cgit.freedesktop.org/piglit/tree/tests/perf/drawoverhead.c