[Mesa-dev] [PATCH 05/22] i965: correctly assign SamplerCount of INTERFACE_DESCRIPTOR_DATA

Kenneth Graunke kenneth at whitecape.org
Tue Sep 26 07:52:45 UTC 2017


On Monday, September 25, 2017 5:46:32 AM PDT Lionel Landwerlin wrote:
> I'm genuinely surprised we didn't noticed this problem before :|
> 
> Fixes: 71bfb44005bf ("i965: Port brw_cs_state tracked state to genxml.")
> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Cc: "17.2" <mesa-stable at lists.freedesktop.org>

I'm not - these fields are just used for prefetching the sampler states,
so programming too small a number will just prefetch fewer of them.  No
big deal, certainly not going to hurt correctness.

I probably wouldn't bother Cc'ing it to stable.

That said, nice find :)  We should definitely fix this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170926/c9ddf163/attachment.sig>


More information about the mesa-dev mailing list