[Mesa-dev] [PATCH v3 4/4] meson: build "radv" vulkan driver for radeon hardware

[Nirbheek Chauhan]

On Wed, Sep 27, 2017 at 1:11 AM, Dylan Baker <dylan at pnwbakers.com> wrote:
> Quoting Nirbheek Chauhan (2017-09-26 12:29:30)
>> On Tue, Sep 26, 2017 at 9:46 PM, Dylan Baker <dylan at pnwbakers.com> wrote:
>> > This builds and installs, but I haven't had a chance to test it yet.
>> >
>> > v2: - enable radv by default
>> >     - add shader cache support and enforce that it's built for radv
>> > v3: - Fix typo in meson_options (Nicholas)
>> >     - strip trailing 'svn' from llvm version before setting the version
>> >       preprocessor flag (Bas)
>>
>> Should this also be added to the LLVMDependency meson class?
>
> I was looking at that. I'm not sure since I think that 6.0.0svn *should* <
> 6.0.0, but meson just throws the svn away when it does the comparison.

That's version_compare(), which should perhaps follow rpm's version
comparison algorithm[1], since that is also what pkg-config and many
other package managers use, but in practice almost all libraries use
semantic versioning (which is what it implements right now).

For the LLVMDependency class, as a start I think we could strip the
'svn' from the version since most things aren't really ready for alpha
to be present in version numbers. It's up to you though, since you
wrote the class and are more familiar with llvm itself.

1. http://blog.jasonantman.com/2014/07/how-yum-and-rpm-compare-versions/