[Mesa-dev] [PATCH] egl/wayland: Make wayland_drm_init declaration match the implementation

[Daniel Stone]

Hi,

On 20 September 2017 at 19:02, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> Krzysztof Sobiecki (sobkas) provided a more elaborate fix on IRC,
> which I've applied ~15 minutes before this patch went out.
>
> Sorry about breaking things :-(

Even with the compile fix, this made Wayland compositors instantly die
when an accelerated client connected. I've pushed this revert:

commit 5b7e65136440f60a6afe85c9517f42861ee07224 (fdo/master)
Author: Daniel Stone <daniels at collabora.com>
Date:   Fri Sep 22 15:40:59 2017 -0700

    Revert "wayland-drm: constify the callbacks struct"

    The wayland-drm callback struct is referenced, rather than duplicated,
    inside wayland-drm. Constifying this struct involved moving it on to the
    stack; as a result, starting any EGL client on Wayland called into
    random stack memory, and killed the compositor.

    This reverts commit 1d0be5b3fe548ee33d4520092f583c76d42510a6 and
    39d539e321c6c97433a15660c9d9a20ad8657ff0.

    Signed-off-by: Daniel Stone <daniels at collabora.com>
    Cc: Emil Velikov <emil.velikov at collabora.com>
    Cc: Krzysztof Sobiecki <sobkas at gmail.com>
    Fixes: 1d0be5b3fe54 ("wayland-drm: constify the callbacks struct")

Cheers,
Daniel