[Mesa-dev] [PATCH] anv: Remove base_vertex/instance from push_constants

[Lionel Landwerlin]

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 28/09/17 01:02, Jason Ekstrand wrote:
> This is just legacy cruft.  We don't push these values; we pass them in
> as vertex attributes.
> ---
>   src/intel/vulkan/anv_private.h | 7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
> index 3ba623a..b58c803 100644
> --- a/src/intel/vulkan/anv_private.h
> +++ b/src/intel/vulkan/anv_private.h
> @@ -1560,13 +1560,6 @@ struct anv_push_constants {
>      /* Push constant data provided by the client through vkPushConstants */
>      uint8_t client_data[MAX_PUSH_CONSTANTS_SIZE];
>   
> -   /* Our hardware only provides zero-based vertex and instance id so, in
> -    * order to satisfy the vulkan requirements, we may have to push one or
> -    * both of these into the shader.
> -    */
> -   uint32_t base_vertex;
> -   uint32_t base_instance;
> -
>      /* Image data for image_load_store on pre-SKL */
>      struct brw_image_param images[MAX_IMAGES];
>   };