[Mesa-dev] [PATCH 7/9] wayland-drm: static inline wayland_drm_buffer_get

[Emil Velikov]

On 20 September 2017 at 15:06, Daniel Stone <daniel at fooishbar.org> wrote:
> Hi Emil,
>
> On 19 September 2017 at 11:25, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 15 September 2017 at 16:41, Daniel Stone <daniel at fooishbar.org> wrote:
>>> On 15 September 2017 at 16:13, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>>> Right, I'm looking through both functions and I'm struggling a bit.
>>>> Can I bother you with sending a patch?
>>>
>>> Sure. This is only compile-tested, but: https://hastebin.com/mudacudeya
>>>
>> It looks a bit icky and my Wayland knowledge is limited to actually review it.
>>
>> I still think that we're trying to do different things - me simplify
>> things, while you're focusing on fixing a bug.
>
> I like the idea of the simplification, but it's just that a) it can't
> actually be simplified that far, and b) whilst we still rely on
> consistent resolution of wl_buffer_interface, your proposed change may
> actually _introduce_ a bug.
>
Right, I did not see that one. Can you share your train of thought?

Thanks
Emil