[Mesa-dev] [PATCH v2 6/9] egl/tizen: add tizen specific implementations for BindWaylandDisplayWL/UnbindWaylandDisplayWL/QueryWaylandBufferWL
Emil Velikov
emil.l.velikov at gmail.com
Thu Sep 28 14:27:16 UTC 2017
On 17 September 2017 at 19:01, Gwan-gyeong Mun <elongbug at gmail.com> wrote:
> Tizen platform (actually WL_TBM protocol) internally processes similiar actions
> such as mesa's BindWaylandDisplayWL/UnbindWaylandDisplayWL/QueryWaylandBufferWL.
> So the platform_tizen.c needs to implemment BindWaylandDisplayWL,
> UnbindWaylandDisplayWL and QueryWaylandBufferWL apart from mesa's.
>
> - tizen's enlightenment wayland display server calls wayland_tbm_server_init()
> which processes described tasks.
>
> - section TPL-EGL and Wayland Server and Client
> from https://wiki.tizen.org/3.0_Porting_Guide/Graphics_and_UI/OpenGL
>
> "Tizen uses the wl_tbm protocol instead of wl_drm. The wl_tbm protocol is
> born for sharing the buffer(tbm_surface) between the wayland_client and
> wayland_server. Although the wayland_tbm_server_init and wayland_tbm_client_init
> pair is a role for the eglBindWaylandDisplayWL, the EGL driver is required
> to implement the entrypoints for the eglBindWaylandDisplayWL and
> eglUnbindWaylandDisplayWL as dummy."
>
> referenced materials:
> [1] https://wiki.tizen.org/3.0_Porting_Guide/Graphics_and_UI/OpenGL
> [2] repository: git://git.tizen.org/platform/core/uifw/wayland-tbm (branch: tizen)
>
> Signed-off-by: Mun Gwan-gyeong <elongbug at gmail.com>
> ---
> + switch (tbm_format) {
> + case TBM_FORMAT_ARGB8888:
> + *value = EGL_TEXTURE_RGBA;
> + return EGL_TRUE;
> +#pragma GCC diagnostic push
> +#pragma GCC diagnostic ignored "-Wswitch"
> + case TBM_FORMAT_XRGB8888:
> + case TBM_FORMAT_RGB565:
> +#pragma GCC diagnostic pop
> + *value = EGL_TEXTURE_RGB;
> + return EGL_TRUE;
Please flesh into a helper, getting rid of the pragmas and using a
default return EGL_FALSE case.
Thanks
Emil
More information about the mesa-dev
mailing list