[Mesa-dev] [PATCH 03/12] i965: Fix support for disassembling 64-bit integer immediates

Iago Toral itoral at igalia.com
Fri Sep 29 11:54:36 UTC 2017


Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

On Thu, 2017-09-28 at 23:05 -0700, Matt Turner wrote:
> The type suffixes were wrong, and the 16 was missing the 0 prefix.
> 
> Fixes: 92f787ff86ab ("i965: Add support for disassembling 64-bit
> integer immediates")
> ---
>  src/intel/compiler/brw_disasm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/intel/compiler/brw_disasm.c
> b/src/intel/compiler/brw_disasm.c
> index e2675b5f4c..2043d64b27 100644
> --- a/src/intel/compiler/brw_disasm.c
> +++ b/src/intel/compiler/brw_disasm.c
> @@ -1012,10 +1012,10 @@ imm(FILE *file, const struct gen_device_info
> *devinfo, enum brw_reg_type type,
>  {
>     switch (type) {
>     case BRW_REGISTER_TYPE_UQ:
> -      format(file, "0x%16lxUD", brw_inst_imm_uq(devinfo, inst));
> +      format(file, "0x%016lxUQ", brw_inst_imm_uq(devinfo, inst));
>        break;
>     case BRW_REGISTER_TYPE_Q:
> -      format(file, "%ldD", brw_inst_imm_uq(devinfo, inst));
> +      format(file, "%ldQ", brw_inst_imm_uq(devinfo, inst));
>        break;
>     case BRW_REGISTER_TYPE_UD:
>        format(file, "0x%08xUD", brw_inst_imm_ud(devinfo, inst));


More information about the mesa-dev mailing list