[Mesa-dev] [PATCH 00/19] radv: meta operations & decompression cleanups

[Samuel Pitoiset]

Hi,

After glancing at this code a lot, it appears that some cleanups are
needed. I think it's also definitely possible to reduce the meta-related
code, I have something in mind but not yet finished.

Please review, Thanks!

Samuel Pitoiset (19):
  radv: skip the decompression color pass when CMASK/FMASK/DCC are
    disabled
  radv: do not allocate CMASK for unsupported 128 bit formats
  radv: rework DCC/CMASK/FMASK/HTILE allocations
  radv: inline blit2d_unbind_dst()
  radv: use pipeline handles instead of objects for meta clear
    operations
  radv: inline destroy_render_pass()
  radv: do not need to double zero-init the meta state structures
  radv: remove the resummarize decompress depth state
  radv: remove radv_layout_is_htile_compressed()
  radv: add radv_vi_dcc_enabled() helper
  radv: remove unused param in
    radv_handle_{cmask,dcc}_image_transition()
  radv: add radv_attachment_needs_clear() helper
  radv: add radv_subpass_clear_attachment() helper
  radv: drop useless check in depth_view_can_fast_clear()
  radv: drop useless param in emit_depth_decomp()
  radv: select the pipeline outside of emit_fast_clear_flush()
  radv: cleanup radv_device_finish_meta_XXX() helpers
  radv: do not check the number of levels when doing fast htile
  radv: remove unused radv_meta_state::btoi::render_pass handle

 src/amd/vulkan/radv_cmd_buffer.c      |  24 ++--
 src/amd/vulkan/radv_device.c          |   2 +-
 src/amd/vulkan/radv_image.c           |  96 ++++++++++------
 src/amd/vulkan/radv_meta.h            |   3 -
 src/amd/vulkan/radv_meta_blit.c       |  92 ++++++---------
 src/amd/vulkan/radv_meta_blit2d.c     |  63 ++++------
 src/amd/vulkan/radv_meta_buffer.c     |  47 +++-----
 src/amd/vulkan/radv_meta_bufimage.c   | 104 ++++++-----------
 src/amd/vulkan/radv_meta_clear.c      | 210 ++++++++++++++++------------------
 src/amd/vulkan/radv_meta_decompress.c |  98 ++++------------
 src/amd/vulkan/radv_meta_fast_clear.c |  52 ++++-----
 src/amd/vulkan/radv_meta_resolve.c    |  17 +--
 src/amd/vulkan/radv_meta_resolve_cs.c |   1 -
 src/amd/vulkan/radv_meta_resolve_fs.c |   2 -
 src/amd/vulkan/radv_pipeline.c        |   1 -
 src/amd/vulkan/radv_private.h         |  30 ++---
 src/amd/vulkan/radv_query.c           |   2 -
 17 files changed, 335 insertions(+), 509 deletions(-)

-- 
2.14.2