[Mesa-dev] [PATCH] intel: Always set Cube Face Enables for all surfaces.

[Jason Ekstrand]

On September 30, 2017 12:29:56 AM Matt Turner <mattst88 at gmail.com> wrote:

> On Fri, Sep 29, 2017 at 10:54 PM, Kenneth Graunke <kenneth at whitecape.org> 
> wrote:
>> These shouldn't matter for non-cubes, and we always enable them all
>> for cubes, so we may as well set them all the time.  We can just mark
>> the fields "mbo" (must be one) and genxml will automatically set them
>> for us, and we never even have to think about them.
>
> I don't like overloading the concept of must-be-zero/one. It really
> means that the hardware requires bits to be unset/set.

Agreed.  I'd rather we just set them since they do have meaning.

> It looks like the if GEN_GEN check in isl_surface_state.c can go away
> if we just make all of the genxml match. Not sure why we made gen8+
> individual bits and earlier ones a uint bitfield. I think it's really
> all the same.

Mostly because I couldn't decide which of the two I liked better so I never 
unified it.