[Mesa-dev] [PATCH 4/4] swr: Fix include for createPromoteMemoryToRegisterPass

Kyriazis, George george.kyriazis at intel.com
Mon Apr 2 15:48:03 UTC 2018


Please use LLVM defines consistent with the surrounding code.  Surrounding code uses LLVM_VERSION_MAJOR / LLVM_VERSION_MINOR.

This code should then be:

#if LLVM_VERSION_MAJOR >= 7
…
#endif

Thank you!

George

> On Apr 1, 2018, at 3:05 PM, Vinson Lee <vlee at freedesktop.org> wrote:
> 
> On Sun, Apr 1, 2018 at 1:10 AM, Mike Lothian <mike at fireburn.co.uk> wrote:
>> Include llvm/Transforms/Utils.h with the newest LLVM 7
>> 
>> Signed-of-by: Mike Lothian <mike at fireburn.co.uk>
>> ---
>> src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp | 3 +++
>> 1 file changed, 3 insertions(+)
>> 
>> diff --git a/src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp b/src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp
>> index 031bced8a0..d726d4844e 100644
>> --- a/src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp
>> +++ b/src/gallium/drivers/swr/rasterizer/jitter/jit_pch.hpp
>> @@ -67,6 +67,9 @@ using PassManager = llvm::legacy::PassManager;
>> #include "llvm/Support/DynamicLibrary.h"
>> #include "llvm/Transforms/IPO.h"
>> #include "llvm/Transforms/Scalar.h"
>> +#if HAVE_LLVM >= 0x0700
>> +#include <llvm/Transforms/Utils.h>
>> +#endif
>> #include "llvm/Support/Host.h"
>> #include "llvm/Support/DynamicLibrary.h"
>> 
>> --
>> 2.16.3
>> 
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> 
> The added include uses <> delimiters whereas the other includes use ""
> delimiters.
> 
> Tested-by: Vinson Lee <vlee at freedesktop.org>



More information about the mesa-dev mailing list