[Mesa-dev] [PATCH v3] i965: Extend the negative 32-bit deltas to 64-bits
Sergii Romantsov
sergii.romantsov at gmail.com
Wed Apr 4 06:51:31 UTC 2018
Gen8+ use 48-bit address relocations so need to extend the sign
to 64-bit return value. Without it we have higher bits zeroed
and missing the negavive values.
Haswell and older use 32-bit deltas so are unaffected by this issue.
v2:
used int32_t fucntion parameter instead of explicit type conversion.
v3:
added "Cc" into commit-message.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101408
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
Cc: "18.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Sergii Romantsov <sergii.romantsov at globallogic.com>
Tested-by: Andriy Khulap <andriy.khulap at globallogic.com>
Tested-by: Mark Janes <mark.a.janes at intel.com>
---
src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
index ebc02ff..7286140 100644
--- a/src/mesa/drivers/dri/i965/intel_batchbuffer.c
+++ b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
@@ -1079,7 +1079,7 @@ brw_batch_references(struct intel_batchbuffer *batch, struct brw_bo *bo)
static uint64_t
emit_reloc(struct intel_batchbuffer *batch,
struct brw_reloc_list *rlist, uint32_t offset,
- struct brw_bo *target, uint32_t target_offset,
+ struct brw_bo *target, int32_t target_offset,
unsigned int reloc_flags)
{
assert(target != NULL);
--
2.7.4
More information about the mesa-dev
mailing list