[Mesa-dev] [PATCH] meson: fix megadriver symlinking

Dylan Baker dylan at pnwbakers.com
Thu Apr 5 17:49:50 UTC 2018


Quoting Emil Velikov (2018-04-05 07:58:22)
> On 4 April 2018 at 18:45, Dylan Baker <dylan at pnwbakers.com> wrote:
> > Which should be relative instead of absolute.
> >
> > Fixes: f7f1b30f81e842db6057591470ce3cb6d4fb2795
> >        ("meson: extend install_megadrivers script to handle symmlinking")
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105567
> > Signed-off-by: Dylan Baker <dylan.c.baker at intel.com>
> > ---
> >  bin/install_megadrivers.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/bin/install_megadrivers.py b/bin/install_megadrivers.py
> > index 86bfa359188..7931a544bd2 100755
> > --- a/bin/install_megadrivers.py
> > +++ b/bin/install_megadrivers.py
> > @@ -58,7 +58,7 @@ def main():
> >              while ext != '.so':
> >                  if os.path.exists(name):
> >                      os.unlink(name)
> > -                os.symlink(driver, name)
> > +                os.symlink(each, name)
> At a later stage, can we update the script to use more obvious names.

Yeah, I thought about that too, but this is fix that should land for 18.0.1, so
I wanted to minimize the churn.

Dylan

> 
> As-is patch does the job and is
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> -Emil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180405/4268e4b4/attachment.sig>


More information about the mesa-dev mailing list